-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build options examples #45
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please share with community for someone to try it out before the merge. Think it should also be higher in the document. Nearer top
We have a slight conflict now @ivanayov due to some ordering changes. Please can you rebase or re-submit in a new PR? Alex |
6f6a0dc
to
157c93a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs improvements, please.
@ivanayov PTAL. |
@alexellis I've changed the code example. |
@alexellis since the last update I don't have anything to add/change, unless there are new comments on the PR |
This adds an example of how to practically use `build-option` with pillow for Python Signed-off-by: Ivana Yovcheva (VMware) <[email protected]>
@alexellis conflicts from master are now resolved |
This adds an example how to use
build-option
with pillow for PythonSigned-off-by: Ivana Yovcheva (VMware) [email protected]