Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to enable authorization for NATS.
New chart options:
nats.authorization.enabled
false
nats.authorization.generateToken
true
nats.authorization.tokenSecret
nats-token
New OpenFaaS installations can enable NATS authorization simply by setting
nats.authorization.enabled
.To enable authorization for an existing installation users will need to create the
nats-token
secret manually before they update the OpenFaaS deployment withnats.authorization.enabled=true
.Users that are using external NATS also need to create the secret manually and enable authorization on the external NATS deployment.
Why is this needed?
Support authentication for NATS to prevent unauthenticated access from functions or other components.
Who is this for?
What company is this for? Are you listed in the ADOPTERS.md file?
How Has This Been Tested?
Verified all components connecting to NATS (gateway, queue-worker, event-worker) could be deployed with and without authentication enabled.
Verified the NATS token secret is created on helm install when
nats.authorization.generateToken
istrue
.Types of changes
Checklist:
git commit -s