WebViewUI: Open drawer instead of going back to Sitemaps #3706
Conversation
When pressing the 'back to app' button the drawer is opened instead of closing the UI. This way users can switch faster between e.g. MainUI and notifications. Signed-off-by: mueller-ma <[email protected]>
| if (temporaryPage != null) { | ||
| temporaryPage = null | ||
| activity.updateTitle() | ||
| updateActionBarState() | ||
| updateFragmentState(FragmentUpdateReason.PAGE_UPDATE) | ||
| updateConnectionState() | ||
| } |
There was a problem hiding this comment.
This code needs to be restored otherwise the action bar doesn't show up when switching from MainUI to Sitemaps.
|
Thanks @mueller-ma ! This is a nice improvement. I think in hindsight the name "exitToApp" was probably not what we wanted, it should have been named "menuButtonClicked" or something, as exiting was not really what we intended. ah well, naming stuff is hard. |
|
I'm not too sure I'm a fan of that, because 'exitToApp' exactly matches the icon/appearance of the button. That means with this proposal we'd have 2 buttons opening 2 different drawers in MainUI, which look completely different. |
|
The only other app which uses "exitToApp" is the IOS client, and we also show the side menu. I don't think "exiting" is really what we intended in any situation.
Hmm, not sure i understand, what two buttons ? and what 2 drawers? |
|
Main UI could be changed to display the same right drawer as in the browser, but make the entries configurable via the app. |
|
The IOS client does something similar to the Main UI, it calls |
|
In any case, it would be nice if the MainUI and SItemaps could both be the primary interface in Android, right now the Main UI UX is clunky with it exiting to a sitemap every time that button is pressed. |
Hamburger button on the left -> opens MainUI drawer
That's about what I intended to suggest above: Make it possible for the app to inject items into MainUI's drawer, and get called back once they're selected. |
Gotcha, Understood. Right now this works OK on IOS b/c its native menu comes in on the right side of the app, matching the MainUI button on the right side, could we maybe reuse the existing android side menu, just switch sides when in the main UI ? I worry about trying to do much magic in mixing the MainUI and NativeUI menu together. |
I really don't think opening the drawer from different sides, depending from where/when it's opened (sitemap vs. Main UI), makes sense UX wise. Right hand side drawers are not really a thing in Android.
Well, at some point we'll need to decide whether we want seamless MainUI integration or not. If the answer is yes, there's a price to pay for that, which is some additional complexity... |
|
I would suggest as a stop gap until we can make a hybrid menu in the MainUI, we at least open the native drawer on the left when the right menu button is clicked. While not totally ideal, its far superior to the experience right now , and gives us time to work on a longer term solution. |
When pressing the 'back to app' button the drawer is opened instead of closing the UI. This way users can switch faster between e.g. MainUI and notifications.