Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Welcome party in lua #4818

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Welcome party in lua #4818

wants to merge 7 commits into from

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Migrate party system to Lua as much as possible. The C++ class and some Lua binds will be retained.

@MillhioreBT
Copy link
Contributor

It's great that you want to move the system to lua, but why break backwards compatibility by removing the EventCallback link? You could simply connect the EventCallback to the PacketHandler events respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramon-bernardo @MillhioreBT