Refactor events: Extracted into tfs::events namespace #4831

ramon-bernardo · 2024-11-10T05:34:15Z

Pull Request Prelude

I have followed proper The Forgotten Server code styling.
I have read and understood the contribution guidelines before making this PR.
I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Nothing complicated here; Events has been moved to tfs::events

src/events.cpp

+	int32_t onSpawn = -1;
+} monsterHandlers;
+
+bool load_from_xml()


ramon-bernardo added 2 commits November 10, 2024 02:32

Refactor events: Extracted into tfs::events namespace

8858aea

Rename event to fix ambiguous

d6025be

github-advanced-security bot found potential problems Nov 10, 2024

View reviewed changes

src/events.cpp

int32_t onSpawn = -1;

} monsterHandlers;

bool load_from_xml()

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 139 lines.

EPuncker requested review from ranisalt and MillhioreBT November 10, 2024 16:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor events: Extracted into tfs::events namespace #4831

Refactor events: Extracted into tfs::events namespace #4831

ramon-bernardo commented Nov 10, 2024

Refactor events: Extracted into tfs::events namespace #4831

Are you sure you want to change the base?

Refactor events: Extracted into tfs::events namespace #4831

Conversation

ramon-bernardo commented Nov 10, 2024

Pull Request Prelude

Changes Proposed