Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): revert unmatched rule error #7257

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

camchenry
Copy link
Collaborator

@camchenry camchenry commented Nov 12, 2024

This is causing a lot of errors currently such as #7233. I think we need to handle rule names more robustly first:

then, I think we can revisit this and maybe implement it as an actual lint plugin too? #7086

Copy link

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Nov 12, 2024
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on Graphite Graphite

@camchenry camchenry marked this pull request as ready for review November 12, 2024 16:12
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #7257 will not alter performance

Comparing 11-12-fix_linter_revert_unmatched_rule_error (9594117) with main (c4ed230)

Summary

✅ 30 untouched benchmarks

oxlint.config.json Outdated Show resolved Hide resolved
@camchenry camchenry force-pushed the 11-12-fix_linter_revert_unmatched_rule_error branch from 9594117 to be47d56 Compare November 12, 2024 16:20
@camchenry
Copy link
Collaborator Author

Noting that we are still accumulating the unknown rules internally, but we just won't report it to users anymore.

@Boshen Boshen merged commit df5c535 into main Nov 13, 2024
26 of 27 checks passed
@Boshen Boshen deleted the 11-12-fix_linter_revert_unmatched_rule_error branch November 13, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants