-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity package #156
Unity package #156
Conversation
Change name to Package
Will it be easier for users if we do upload it to NPM? We'd still need some automation to keep dll files updated so might as well publish the full package? |
Are you able to install https://www.npmjs.com/package/com.pakrym.jab ? |
Navigate to the Packages directory of your project.
|
Your setup works and I successfully installed the package, But if you want to create your own registry for the Unity package I'll suggest checking out OpenUPM it has a Unity specific package library, package discovery and CLI tools Edit: seems like it's not really one or the other, uploading to npm might help some users, git URL will always be available, and OpenUPM seems to do the import themselves so there is nothing you really have to do except raise the version number |
If you don't mind, let's start with an NPM package. Keeping binaries up-to-date in git is a bit tricky and grows the repo size. I'll think about automating github url publishing in the meantime. |
Np, let me know if I can help :) |
TIL :) Do you mind helping me out with that and pushing a meta file for README into this PR? |
Thank you so much for your help @AlonTalmi ! |
Unity users will be able to install Jab by importing:
https://github.com/pakrym/jab.git?path=src/Jab.Unity/Package
Tested with my fork's branch at URL:
https://github.com/AlonTalmi/jab.git?path=src/Jab.Unity/Package#UnityNpmPackage
(In Unity: Window ↝ Package Manager ↝ '+' ↝ Add package from git URL...)
I already added package.json, Dlls and meta files, until you decide to rename one of the packages this should be enough.
Do notice that *.meta files are ignored in your .gitignore, I forcefully tracked them, but maybe it would be a better idea to make a .gitignore exceptions for them?
As for the build process, I don't have a lot of experience, help will be appreciated @pakrym
Edit: I understood I might have confused you, I created an npm package using npm init, but we don't actually need to upload the package to npm, it's just the structure Unity uses, it will works straight from this repository.
If you merge this PR it's enough to be installable through Unity, we just need to make sure newly built dlls are copied to the package directory