-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chainSpec: Add Checkpoint
extension to the chainSpec
#3271
Open
lexnv
wants to merge
11
commits into
master
Choose a base branch
from
lexnv/checkpoint-proof
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
added
A1-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
R0-silent
Changes should not be mentioned in any release notes
I5-enhancement
An additional feature request.
D1-medium
Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
labels
Feb 8, 2024
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A1-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
D1-medium
Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
I5-enhancement
An additional feature request.
R0-silent
Changes should not be mentioned in any release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Checkpoint
extension is needed for the lightclient to synchronize faster to the head of the chain.This is a replacement for the current
lightSyncState
, which doesn't expose directly any particular data about the grandpa or babe; and therefore doesn't cause a breaking change when switching consensus mechanisms (sassafras).Instead, the finalized block's
:code
section is exposed indirectly in a storage proof. Then, the user of the checkpoint will regenerate the state of the consensus using the runtime APIs.The
checkpoint
is a Merkle proof that consists of::code
and:heappages
storage proofsBabeApi_current_epoch
,BabeApi_next_epoch
,BabeApi_configuration
,GrandpaApi_grandpa_authorities
, andGrandpaApi_current_set_id
call proofsFor now, the
checkpoint
extension is added next to thelightSyncState
. A future PR will deprecate and remove thelightSyncState
.This PR validates the proposal from: #60; as well as unblocks the
chainSpec
V2 method which awaits a consensus on thecheckpoint
format: paritytech/json-rpc-interface-spec#124.Testing Done
:code
section needed for users to regenerate the consensus state.