Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated getting started links #123

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

jhauga
Copy link
Contributor

@jhauga jhauga commented Jul 15, 2024

Updated the getting-started links and a broken link, made minor edits to copy, and changed full text and redundant uri in instructions to text that fits with context (excluding when repo paths used). This was to save time, and make the documentation easier to read.

Used a bash script to make most of the edits, seeing as mostly find/replace. The script file used was a slight variation of:
gist - recurse_and_replace.sh

To Expand - the items changed were:
  1. FULL URI - getting-started/authentication
    • https://developers.pinterest.com/docs/getting-started/authentication/
    • to
    • https://developers.pinterest.com/docs/getting-started/authentication-and-scopes/
  2. RENDERED LINK TEXT - https://developers.pinterest.com/apps/
    • [https://developers.pinterest.com/apps/](https://developers.pinterest.com/apps/)
    • to
    • the [apps dashboard](https://developers.pinterest.com/apps/)
  3. FULL URI - getting-started/scopes
    • https://developers.pinterest.com/docs/getting-started/scopes/
    • to
    • https://developers.pinterest.com/docs/getting-started/authentication-and-scopes/#pinterest-scopes
  4. REDUNDANT LINK - inline http://localhost:8085
    • http://localhost:8085 NOTE - rendered as link and had 1 occurence in php/README.md
    • to
    • http://localhost:8085
  5. MISSING LOCAL REPO FILE - ./src/v5/oauth_scope.py
    • .\/src\/v5\/oauth_scope.py
    • to
    • .\/src\/oauth_scope.py

* update non redirected links

Updating the incorrectly redirected links. Save source code programmers time.

* update non redirected links and documentation edits

Updated non redirects and made minor edits.

* update getting started links

* updated getting started links
@jhauga jhauga marked this pull request as draft July 15, 2024 00:17
@davidchaiken
Copy link
Collaborator

Thanks for the PR. I really appreciate your help and will review the changes sometime this week.

@jhauga jhauga marked this pull request as ready for review July 15, 2024 00:50
```
$ php -S localhost:8085
```
6. [Click here](http://localhost:8085/) or point your browser at `http://localhost:8085`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only line edited. Copied and pasted full contents from editor to GitHub may have caused new line difference.

@davidchaiken
Copy link
Collaborator

Thanks for the PR. I'll fix the python build error ASAP.

@davidchaiken davidchaiken merged commit 75bd481 into pinterest:main Jul 15, 2024
1 of 2 checks passed
davidchaiken pushed a commit that referenced this pull request Jul 15, 2024
davidchaiken added a commit that referenced this pull request Jul 15, 2024
Co-authored-by: David Chaiken <[email protected]>
@jhauga jhauga deleted the updated_getting_started_links branch July 16, 2024 14:58
davidchaiken added a commit that referenced this pull request Jul 25, 2024
* fix lint issue with PR #123

* PINDP-3072: update doc links

* fixed a couple of links that were reversed

---------

Co-authored-by: David Chaiken <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants