-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated getting started links #123
Merged
davidchaiken
merged 2 commits into
pinterest:main
from
jhauga:updated_getting_started_links
Jul 15, 2024
Merged
updated getting started links #123
davidchaiken
merged 2 commits into
pinterest:main
from
jhauga:updated_getting_started_links
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update non redirected links Updating the incorrectly redirected links. Save source code programmers time. * update non redirected links and documentation edits Updated non redirects and made minor edits. * update getting started links * updated getting started links
Thanks for the PR. I really appreciate your help and will review the changes sometime this week. |
jhauga
commented
Jul 15, 2024
jhauga
commented
Jul 15, 2024
``` | ||
$ php -S localhost:8085 | ||
``` | ||
6. [Click here](http://localhost:8085/) or point your browser at `http://localhost:8085`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only line edited. Copied and pasted full contents from editor to GitHub may have caused new line difference.
davidchaiken
approved these changes
Jul 15, 2024
Thanks for the PR. I'll fix the python build error ASAP. |
davidchaiken
pushed a commit
that referenced
this pull request
Jul 15, 2024
davidchaiken
added a commit
that referenced
this pull request
Jul 15, 2024
Co-authored-by: David Chaiken <[email protected]>
davidchaiken
added a commit
that referenced
this pull request
Jul 25, 2024
* fix lint issue with PR #123 * PINDP-3072: update doc links * fixed a couple of links that were reversed --------- Co-authored-by: David Chaiken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the getting-started links and a broken link, made minor edits to copy, and changed full text and redundant uri in instructions to text that fits with context (excluding when repo paths used). This was to save time, and make the documentation easier to read.
Used a bash script to make most of the edits, seeing as mostly find/replace. The script file used was a slight variation of:
gist - recurse_and_replace.sh
To Expand - the items changed were:
https://developers.pinterest.com/docs/getting-started/authentication/
https://developers.pinterest.com/docs/getting-started/authentication-and-scopes/
https://developers.pinterest.com/apps/
[https://developers.pinterest.com/apps/](https://developers.pinterest.com/apps/)
the [apps dashboard](https://developers.pinterest.com/apps/)
https://developers.pinterest.com/docs/getting-started/scopes/
https://developers.pinterest.com/docs/getting-started/authentication-and-scopes/#pinterest-scopes
http://localhost:8085
.\/src\/v5\/oauth_scope.py
.\/src\/oauth_scope.py