fix to incorrect error message when wrong refresh token is passed in

pinterest · Nov 29, 2023 · a19a4a0 · a19a4a0
1 parent 929027c
commit a19a4a0
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/pinterest/utils/refresh_access_token.py b/pinterest/utils/refresh_access_token.py
@@ -50,7 +50,8 @@ def get_new_access_token(
             body="Authentication error. " +
             "Kindly check if the following variables are correct: [PINTEREST_ACCESS_TOKEN] or " +
             "[PINTEREST_APP_ID, PINTEREST_APP_SECRET, PINTEREST_REFRESH_ACCESS_TOKEN]. " +
-            f"Response from server: {response.body}"
+            f"Response from server: {response.data}",
+            http_resp=response
             )
     if response.status != 200:
         raise SdkException(http_resp=response)

diff --git a/tests/src/pinterest/client/client_test.py b/tests/src/pinterest/client/client_test.py
@@ -3,6 +3,7 @@
 from unittest.mock import patch
 import unittest
 import subprocess
+from pinterest.utils.sdk_exceptions import SdkException
 
 from pinterest.client import PinterestSDKClient
 
@@ -52,3 +53,35 @@ def test_set_default_refresh_token(self, load_dotenv_mock):
         self.assertEqual(refresh_token, PINTEREST_REFRESH_ACCESS_TOKEN)
         self.assertEqual(app_id, PINTEREST_APP_ID)
         self.assertEqual(app_secret, PINTEREST_APP_SECRET)
+
+    @mock.patch.dict(
+        os.environ,
+        {
+            "PINTEREST_APP_ID": "test_app_id",
+            "PINTEREST_APP_SECRET": "test_app_secret",
+         },
+        clear=True
+    )
+    @patch('dotenv.load_dotenv')
+    def test_set_bad_refresh_token(self, load_dotenv_mock):
+        load_dotenv_mock.return_value = None
+        refresh_token = 'refresh_token'
+        app_id = '12345'
+        app_secret = '123456asdfg'
+
+        from pinterest.config import PINTEREST_REFRESH_ACCESS_TOKEN
+        from pinterest.config import PINTEREST_APP_ID
+        from pinterest.config import PINTEREST_APP_SECRET
+        self.assertNotEqual(refresh_token, PINTEREST_REFRESH_ACCESS_TOKEN)
+        self.assertNotEqual(app_id, PINTEREST_APP_ID)
+        self.assertNotEqual(app_secret, PINTEREST_APP_SECRET)
+
+        try:
+            PinterestSDKClient._get_access_token(
+                refresh_token=refresh_token,
+                app_id=app_id,
+                app_secret=app_secret
+            )
+            self.assertTrue(False)
+        except SdkException as e:
+            self.assertTrue(True)