Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #1031 #1032

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laowantong
Copy link

@laowantong laowantong commented Sep 15, 2024

Describe your changes

The regular result set is now displayed when the configuration option column_local_vars is set.

NB. I was unable to install the whole development environment on my machine. Since the changes are small, I hope they don't break anything.

Issue number

Closes #1031

Checklist before requesting a review

  • Performed a self-review of my code
  • Formatted my code with pkgmt format. Not needed.
  • Added tests (when necessary). Changed one test.
  • Added docstring documentation and update the changelog. Not needed, since the current behaviour was not documented.

📚 Documentation preview 📚: https://jupysql--1032.org.readthedocs.build/en/1032/

@laowantong
Copy link
Author

The failing check asks me to update the changelog (not sure under which version number to insert my description) or to add the label no-changelog to my PR (but I have not the rights to do this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return regular result set even when column_local_vars is set
1 participant