Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Spam Filtering Using Akismet. #599. #614

Closed
wants to merge 6 commits into from
Closed

Support for Spam Filtering Using Akismet. #599. #614

wants to merge 6 commits into from

Conversation

thousandtyone
Copy link
Contributor

PR Contains Fix as described in #599. Entire end to end flow has been tested and works. Here are the high level changes that are done:

  1. Migrated the Akismet projects using Dotnet Upgrade Assistant. More information about this tool is at: https://docs.microsoft.com/en-us/dotnet/core/porting/upgrade-assistant-overview. The migration was smooth without any errors and the entire project was moved over to .NET Core 6.0.
  2. Wrote code to integrate with the project. (Very similar to the old DasBlog project). Note that some simple changes were done to fit in the correct structure. E.g. Akismet with spam moderation works fine and integrates in correct comment moderation framework. Without comment moderation, any spam detected by Akismet is stopped from getting posted using validations.
  3. Config file already had the right XML nodes present but the Models in CS files had some of those attributes commented to uncommented those.

The end to end flows work. More documentation with screenshot of how this works appended with the issue. Happy to make any other changes that you feel might be required.

Added support for Akismet integration.
Adding Akismet project to Solution to Build from with Visual Studio while building the solution.
Rolled back all changes other than adding Akismet project.
Simple code formatting and clean up for esthetics and readability.
…ering.

Included a top level check to not even check for spam if filtering service for spam detection is not set to true.
@thousandtyone
Copy link
Contributor Author

Looks like checks are still failing. Not sure why. Will upgrade the project to .NET 6 and try once more.

@thousandtyone
Copy link
Contributor Author

Tests Failed Probably due to .NET version conflicts. Will try to upgrade from 5.0 to 6.0 and resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant