Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution of the virtual fact on FreeBSD #2744

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Sep 11, 2024

  1. Move Linux-specific resolvers in the linux directory

    Move all files that defines Facter::Resolvers::Linux::* into the
    lib/facter/resolvers/linux directory.  Also only load them on Linux
    systems as they are Linux-specific.
    smortex committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7818e00 View commit details
    Browse the repository at this point in the history
  2. Fix AIX filesystems resolver name

    All other filesystems resolvers are named "filesystems" (plural), so
    match the same name because all these resolvers have the same purpose.
    smortex committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ab513fc View commit details
    Browse the repository at this point in the history
  3. Namespace the container resolver into Linux

    FreeBSD has containers (jails) but already handled through the 'virutal'
    resolver, so for now we just consider Linux being able to handle
    containers as the code aleady depend on Linux-specific resolvers.
    smortex committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a594085 View commit details
    Browse the repository at this point in the history
  4. Fix 'virtual' fact on FreeBSD

    We should not call Linux-specific code from a non-Linux system.  This
    cross-platform utility class needs to skip Linux code when running on a
    non-linux platform.
    smortex committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5322adf View commit details
    Browse the repository at this point in the history