-
-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow expands for retrieval of comments #1003
Conversation
Allow expands for retrieval of comments
Travis CI Errors are the not linked with this pull request changes. The exact same failures can be seen earlier still open pull requests. |
looks like the maintainers want to have the ci system back up and running before agreeing to any new merges. if you want to contribute to get yr pr through have a look here => #896 |
@matthewkeenan please apply last changes in the master branch and resolve the conflicts. |
CI tests are failing on "Lint with tox" stage of CI, yet I cannot see what the actual errors are. |
Black failed in tests/tests.py |
CI issues have been fixed and looks to be all passing now. |
@matthewkeenan some conflicts to resolve :-) |
changes seem good to me. |
Just wanted to check if there's anything else that I need to specifically do help get this pull request accepted. Thanks. Matt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've commited the requested changes.
* Fix: pycontribs#949 Allow expands for retrieval of comments * Move comment deletion before assert call * Black formating * Update tests.py * Update comment * Update client.py * Update client.py * Update client.py * Add type and return information * Update client.py for black style Co-authored-by: Sorin Sbarnea <[email protected]>
Allow expands for retrieval of comments
Fixes: #949