Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow expands for retrieval of comments #1003

Merged
merged 12 commits into from
May 18, 2021

Conversation

matthewkeenan
Copy link
Contributor

@matthewkeenan matthewkeenan commented Feb 26, 2021

Allow expands for retrieval of comments

Fixes: #949

Allow expands for retrieval of comments
@matthewkeenan
Copy link
Contributor Author

Travis CI Errors are the not linked with this pull request changes. The exact same failures can be seen earlier still open pull requests.

@studioj
Copy link
Collaborator

studioj commented Apr 4, 2021

Travis CI Errors are the not linked with this pull request changes. The exact same failures can be seen earlier still open pull requests.

looks like the maintainers want to have the ci system back up and running before agreeing to any new merges.

if you want to contribute to get yr pr through have a look here => #896

@studioj
Copy link
Collaborator

studioj commented May 7, 2021

@matthewkeenan please apply last changes in the master branch and resolve the conflicts.
Thank you

tests/tests.py Show resolved Hide resolved
@matthewkeenan
Copy link
Contributor Author

CI tests are failing on "Lint with tox" stage of CI, yet I cannot see what the actual errors are.

@studioj
Copy link
Collaborator

studioj commented May 10, 2021

CI tests are failing on "Lint with tox" stage of CI, yet I cannot see what the actual errors are.

Black failed in tests/tests.py

@matthewkeenan
Copy link
Contributor Author

CI issues have been fixed and looks to be all passing now.

jira/client.py Outdated Show resolved Hide resolved
@adehad adehad changed the title Fix: #949 Allow expands for retrieval of comments. Fix: #949 May 14, 2021
@adehad adehad linked an issue May 14, 2021 that may be closed by this pull request
@studioj
Copy link
Collaborator

studioj commented May 15, 2021

@matthewkeenan some conflicts to resolve :-)

@studioj
Copy link
Collaborator

studioj commented May 15, 2021

changes seem good to me.
@ssbarnea should give his stamp of approval => maybe we should make this expand possible for more fields?

@ssbarnea ssbarnea closed this May 16, 2021
@ssbarnea ssbarnea reopened this May 16, 2021
@matthewkeenan
Copy link
Contributor Author

Just wanted to check if there's anything else that I need to specifically do help get this pull request accepted. Thanks. Matt

jira/client.py Outdated Show resolved Hide resolved
jira/client.py Outdated Show resolved Hide resolved
@ssbarnea ssbarnea changed the title Allow expands for retrieval of comments. Fix: #949 Allow expands for retrieval of comments May 17, 2021
Copy link
Contributor Author

@matthewkeenan matthewkeenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've commited the requested changes.

@ssbarnea ssbarnea merged commit 630973f into pycontribs:master May 18, 2021
svermeulen pushed a commit to svermeulen/jira that referenced this pull request Oct 31, 2021
* Fix: pycontribs#949

Allow expands for retrieval of comments

* Move comment deletion before assert call

* Black formating

* Update tests.py

* Update comment

* Update client.py

* Update client.py

* Update client.py

* Add type and return information

* Update client.py for black style

Co-authored-by: Sorin Sbarnea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieval of comments missing expand parameter
4 participants