-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-to-github-migration replace roundup summary script #91738
base: main
Are you sure you want to change the base?
Conversation
I've left the "to" field blank in the params in |
Is there anything else I need to do to get this merged? |
I think we need @ewdurbin to set up the template and double-check the code. FTR another alternative was proposed in this post: https://discuss.python.org/t/triaging-reviewing-fixing-issues-and-prs/15365/18 |
|
||
def get_issues(filters: Iterable[str], token: str, all_: bool = True): | ||
"""return a list of results from the Github search API""" | ||
# TODO: if there are more than 100 issues, we need to include pagination |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this TODO be addressed before merge? If not is there something we should put in place to make clear that there weren't magically just 100 issues a given week?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work to implement this report @Harry-Lees!
I have some concerns that are raised in review, but one of the primary ones is that there is no clear way to add the helper functions you mention in the PR description that I can find in the Mailgun UI. Are they required, or can you work around without them?
"""send the report using the Mailgun API""" | ||
params = { | ||
"from": "Cpython Issues <[email protected]>", | ||
"to": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be configured before merge.
"from": "Cpython Issues <[email protected]>", | ||
"to": "", | ||
"subject": "Summary of Python tracker Issues", | ||
"template": "issue-tracker-template", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note To Self: Ensure template name matches when added to Mailgun.
github_token, | ||
False) | ||
|
||
payload = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This payload appears to be missing the following keys to render the proposed template:
timespan
total_diff
References: psf/gh-migration#6
Currently, this script requires the following template in MailGun:
Furthermore, the following helpers were used to calculate number of issues etc.