Update tqdm to 4.67.* #13004
Open
Update tqdm to 4.67.* #13004
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Added mypy suppression because the source just has |
This comment has been minimized.
This comment has been minimized.
| def display( | ||
| self, msg: str | None = ..., pos: int | None = ..., close: bool = ..., bar_style=..., check_delay: bool = ... | ||
| self, *, msg: str | None = ..., pos: int | None = ..., close: bool = ..., bar_style=..., check_delay: bool = ... |
There was a problem hiding this comment.
mypy failure is due to these parameters being keyword-only here but positional-or-keyword in the parent:
typeshed/stubs/tqdm/tqdm/std.pyi
Line 224 in 90842a4
There was a problem hiding this comment.
This seems like an issue in the source library, the implementation for this function is keyword-only: https://github.com/tqdm/tqdm/blob/master/tqdm/contrib/discord.py#L126
There was a problem hiding this comment.
Then we'll need to add a type ignore here with a comment.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12968