Wait for fleet-controller and rancher-webhook deployments #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehejik
force-pushed
the
wait-webhook
branch
from
845aa53
to
1c53897
Compare
|
This PR is basically done and working with already released versions like v2.9.2 but for now proper version of rancher-webhook 104.0.3+up0.5.3 is not merged in rancher/rancher release/v2.9 (for v2.9-head) so the webhook is not installed at all. |
valaparthvi
reviewed
Oct 22, 2024
Comment on lines
+74
to
+76
| kubectl_rollout_deployment_with_timeout 300s rancher cattle-system && \ | ||
| kubectl_rollout_deployment_with_timeout 300s fleet-controller cattle-fleet-system && \ | ||
| kubectl_rollout_deployment_with_timeout 300s rancher-webhook cattle-system |
There was a problem hiding this comment.
Perhaps you could create another macro function that checks all the 3 deployment statuses and simply call the new macro in all targets?
|
Closing as this will be addressed by #191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183
Testrun: