Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topics and make searching by topics simpler #300

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FarazPatankar
Copy link

I have displayed the topics associated with each library and also made them clickable. This way, whenever a user clicks a topic, they can search by that specific topic.

I also created a small demo to see the feature in action.
add-topics

@brentvatne
Copy link
Contributor

brentvatne commented May 9, 2020

hello! thanks for the pr! after seeing this in the ui i'm not totally sure we want it to be featured so prominently. i'll defer to @jonsamp for design ideas here.

also, i noticed that we're already factoring in topics when you search, so that's nice! the ui is the only remaining bit

@FarazPatankar
Copy link
Author

Haha, fair enough. I thought the page could use some colors but I am open to changing whatever.

I was also considering using icons for the platforms but I didn't know what to use for MacOS. 🤔

@brentvatne
Copy link
Contributor

Another thing to consider for these tags - currently we're just using "topics" from GitHub, but this doesn't work too well in some situations, eg: if a library is inside of a monorepo, it can't have its own topics. So we should maybe use npm keywords in addition to GitHub topics and uniq them.

@FarazPatankar
Copy link
Author

I'd be open to that. Are we already fetching that information?

@brentvatne
Copy link
Contributor

not yet - we're just fetching download stats from npm: https://github.com/react-native-community/directory/blob/master/scripts/fetch-npm-data.js

@jonsamp
Copy link
Collaborator

jonsamp commented May 15, 2020

This is a cool feature! Thanks for adding it. Since there are many topics and they act like site links, I think we can style these like links. Here's a design that puts topics below the description. The text-size here is 12px (and the background and border is the same as the link styling):

Screen Shot 2020-05-15 at 10 42 05 AM

Screen Shot 2020-05-15 at 10 44 34 AM

@FarazPatankar
Copy link
Author

Ooh, I like that. I'll try to update and push this over the weekend!

@brentvatne
Copy link
Contributor

lovely @jonsamp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants