test diamonds: reduce needless converters

[tikkss]

GitHub: GH-188

Because date_time is not included in the following csvs.

• diamonds.csv (diamonds dataset inherits from Ggplot2Dataset)
• mpg.csv (fuel economy dataset inherits from Ggplot2Dataset)

Before this change:

$ time ruby test/run-test.rb -t DiamondsTest --verbose=important-only
Finished in 3.702616 seconds.
2 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0
notifications

real    0m4.665s
user    0m4.136s
sys     0m0.226s

After this change:

$ time ruby test/run-test.rb -t DiamondsTest --verbose=important-only
Finished in 3.367821 seconds.
2 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0
notifications

real    0m4.179s
user    0m3.738s
sys     0m0.202s

After this change, the fuel economy dataset test also passed:

$ ruby test/run-test.rb -t FuelEconomyTest --verbose=important-only
Finished in 0.017332 seconds.
2 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications

[kou]

There are more datasets in ggplot2: https://ggplot2.tidyverse.org/reference/#data

Could you check whether all datasets don't have a date_time field or not?

[tikkss]

Sure! I'll check the following unavailable datasets. Thanks!

• Available datasets
  • diamonds
  • mpg
• Unavailable datasets
  • economics economics_long
  • faithfuld
  • midwest
  • msleep
  • presidential
  • seals
  • txhousing
  • luv_colours

[kou]

Ah, Ggploat2Dataset requires defining COLUMN_NAME_MAPPING in subclasses. So other datasets are unavailable now.

OK. Let's use this change. Let's add more converters again when we add support for other datasets and they need more converters.

[tikkss]

Thanks for your review!

OK. Let's use this change. Let's add more converters again when we add support for other datasets and they need more converters.

OK. I see.

[tikkss]

By the way, Could I add the unavailable datasets to the Issues?

[kou]

Yes, please.

[tikkss]

Sure!

[tikkss]

Add the following unavailable datasets to the issues.

#209, #214, #218, #223, #226, #229, #230, #231