test nagoya-university-conversation-corpus: reduce checking #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: red-data-toolsGH-188 Because text file is too big (134,555 rows in total). Before this change: ```console $ time ruby test/run-test.rb -t NagoyaUniversityConversationCorpusTest --verbose=important-only Finished in 3.65658 seconds. 4 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications real 0m4.550s user 0m3.723s sys 0m0.568s ``` After this change: ```console $ time ruby test/run-test.rb -t NagoyaUniversityConversationCorpusTest --verbose=important-only Finished in 0.060458 seconds. 4 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications real 0m0.613s user 0m0.428s sys 0m0.096s ```
kou
reviewed
Sep 6, 2024
tikkss
commented
Sep 6, 2024
| ], | ||
| [ | ||
| first_participants.size, |
There was a problem hiding this comment.
We can also keep this.
Because does not iterates to last in the text files, so we can keep the execution time. Before this change: ```console $ time ruby test/run-test.rb -t NagoyaUniversityConversationCorpusTest --verbose=important-only Finished in 0.060458 seconds. 4 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications real 0m0.613s user 0m0.428s sys 0m0.096s ``` After this change: ```console $ time ruby test/run-test.rb -t NagoyaUniversityConversationCorpusTest --verbose=important-only Finished in 0.062095 seconds. 4 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications real 0m0.622s user 0m0.430s sys 0m0.103s ``` Co-authored-by: Sutou Kouhei <[email protected]>
|
Thanks. |
tikkss
deleted the
test-nagoya-university-conversation-corpus-reduce-checking
branch
|
Thanks for your quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: GH-188
Because text file is too big (134,555 rows in total).
Before this change:
After this change: