Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command_timeout to async client #3436

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yard1
Copy link

@Yard1 Yard1 commented Nov 15, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Currently, socket_timeout is used as both the socket timeout and an asyncio-level timeout. However, if networking is unreliable, it may be preferable to set a shorter socket_timeout than the asyncio timeout - this would allow for the command to fail fast if socket is not receiving any data, but keep the command running if the connection is simply slow, or the amount of data is large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant