-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Osx implementation #21
Open
DanilKorotenko
wants to merge
16
commits into
rflament:master
Choose a base branch
from
DanilKorotenko:osx-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Osx implementation #21
DanilKorotenko
wants to merge
16
commits into
rflament:master
from
DanilKorotenko:osx-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Danil, thank you for your PRs. |
rflament
reviewed
Apr 18, 2021
README.md
Outdated
Rémi Flament - remipouak at gmail.com | ||
|
||
OSX imeplementation - Danil Korotenko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
Fixed typo. |
hey, when mounting a directory under in /Volumes, are running process that read and write in the "real" directory watched by your version ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main implementation of loggedfs is working with the one path specified in the arguments.
It mounts the fuse volume to the path specified and intercepts operations by splitting paths
to realPath and absolutePath.
On OSX, all volumes should be mounted to /Volumes directory.
Only root can mount to the other directory. But if you mount fuse volume as root, the regular user will not have access to it. So this way is not appropriate.
That is why the OSX version is needed to deal with two paths: the one where is fuse volume
mounted (/Volumes/LoggedFS), and the one specified in program arguments.