Skip to content

Commit

Permalink
Switch from rcpputils::fs to std::filesystem (#288)
Browse files Browse the repository at this point in the history
Signed-off-by: Christophe Bedard <[email protected]>
  • Loading branch information
christophebedard authored Feb 23, 2024
1 parent 2b54163 commit abaa07d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
4 changes: 1 addition & 3 deletions qt_gui_cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ endif()

find_package(pluginlib REQUIRED)
find_package(Qt5 REQUIRED COMPONENTS Widgets)
find_package(rcpputils REQUIRED)
find_package(tinyxml2_vendor REQUIRED)
find_package(TinyXML2 REQUIRED)

Expand Down Expand Up @@ -57,7 +56,6 @@ target_link_libraries(${PROJECT_NAME}
${QT_QTGUI_LIBRARY}
Qt5::Widgets
pluginlib::pluginlib
rcpputils::rcpputils
tinyxml2::tinyxml2)

add_subdirectory(src/qt_gui_cpp_shiboken)
Expand All @@ -76,7 +74,7 @@ install(
DESTINATION include/${PROJECT_NAME}
)

ament_export_dependencies(pluginlib rcpputils TinyXML2)
ament_export_dependencies(pluginlib TinyXML2)
ament_export_targets(export_${PROJECT_NAME} HAS_LIBRARY_TARGET)

install(TARGETS ${PROJECT_NAME}
Expand Down
4 changes: 2 additions & 2 deletions qt_gui_cpp/include/qt_gui_cpp/ros_pluginlib_plugin_provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
#include "plugin_provider.h"

#include <pluginlib/class_loader.hpp>
#include <rcpputils/filesystem_helper.hpp>
#include <tinyxml2.h>

#include <QCoreApplication>
Expand All @@ -54,6 +53,7 @@
#include <QObject>
#include <QString>

#include <filesystem>
#include <fstream>
#include <string>
#include <vector>
Expand Down Expand Up @@ -145,7 +145,7 @@ class RosPluginlibPluginProvider

std::string name = class_loader_->getName(lookup_name);
std::string plugin_xml = class_loader_->getPluginManifestPath(lookup_name);
rcpputils::fs::path p(plugin_xml);
std::filesystem::path p(plugin_xml);
std::string plugin_path = p.parent_path().string();

QMap<QString, QString> attributes;
Expand Down
2 changes: 0 additions & 2 deletions qt_gui_cpp/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,10 @@
<build_depend version_gte="0.3.0">python_qt_binding</build_depend>
<build_depend>qt5-qmake</build_depend>
<build_depend>qtbase5-dev</build_depend>
<build_depend>rcpputils</build_depend>
<build_depend>tinyxml2_vendor</build_depend>

<exec_depend version_gte="1.9.23">pluginlib</exec_depend>
<exec_depend version_gte="0.3.0">qt_gui</exec_depend>
<exec_depend>rcpputils</exec_depend>
<exec_depend>tinyxml2_vendor</exec_depend>

<test_depend>ament_cmake_pytest</test_depend>
Expand Down

0 comments on commit abaa07d

Please sign in to comment.