Cleanup qt_dotgraph and make the tests more robust. (backport #296) #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
1. Remove all uses of LooseVersion here. The issue it was protecting against is long gone, and LooseVersion is deprecated. Just remove it. 2. Remove the "simplify" parameter from "add_edge_to_graph". While this is technically an API change, there are no downstream users as far as I can tell and it had no effect. 3. During the test, make sure to replace carriage return with spaces. This ensures that on Windows, the tests will pass correctly. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 4a11ebc)
|
Pulls: #297
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request Cleanup qt_dotgraph and make the tests more robust. #296 done by Mergify.