comment on message loaders notify (was message listeners before) #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
_playhead_positions_cvs
condition variables are consumed by the message loader threads. While the member functionadd_listener(self,topic,listener)
of the bag_timeline is the producer of these condition variables, thus sending notify signal to all the loader threads.The comment was wrong before: "# Notify the message listeners"
The comment I suggest is instead: "# Notify the message loaders to get them ready" to explain that the loaders are notified, and since it can be misleading from a function named
add_listener
, I also stress the fact that it's to prepare them to load the message and, in turn, notify the listener threads.