Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment on message loaders notify (was message listeners before) #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fergian94
Copy link

@fergian94 fergian94 commented Jun 30, 2022

the _playhead_positions_cvs condition variables are consumed by the message loader threads. While the member function add_listener(self,topic,listener) of the bag_timeline is the producer of these condition variables, thus sending notify signal to all the loader threads.
The comment was wrong before: "# Notify the message listeners"
The comment I suggest is instead: "# Notify the message loaders to get them ready" to explain that the loaders are notified, and since it can be misleading from a function named add_listener, I also stress the fact that it's to prepare them to load the message and, in turn, notify the listener threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant