feat: update on twitter ads integration #3805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3805/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3805 +/- ##
========================================
Coverage 89.01% 89.02%
========================================
Files 609 609
Lines 32904 32917 +13
Branches 7772 7781 +9
========================================
+ Hits 29291 29305 +14
+ Misses 3300 3299 -1
Partials 313 313 ☔ View full report in Codecov by Sentry. |
shrouti1507
reviewed
Oct 17, 2024
shrouti1507
reviewed
Oct 17, 2024
yashasvibajpai
approved these changes
Oct 21, 2024
manish339k
approved these changes
Oct 22, 2024
…tination (#3767) * Should filter out reserved attributes from Intercom destination even if they are falsey * Fix presence check to allow null values --------- Co-authored-by: Manish Kumar <[email protected]>
#3767) * Should filter out reserved attributes from Intercom destination even if they are falsey * Fix presence check to allow null values --------- Co-authored-by: Manish Kumar <[email protected]>
Bumps [koa](https://github.com/koajs/koa) and [@types/koa](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/koa). These dependencies needed to be updated together. Updates `koa` from 2.15.0 to 2.15.3 - [Changelog](https://github.com/koajs/koa/blob/2.15.3/History.md) - [Commits](koajs/koa@2.15.0...2.15.3) Updates `@types/koa` from 2.13.12 to 2.15.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/koa) --- updated-dependencies: - dependency-name: koa dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: "@types/koa" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yashasvi Bajpai <[email protected]>
* feat: add missing fields on the pinterest_tag mapping * chore: fix test cases * chore: remove redundant old implementation * chore: remove test cases related to pinterest_tag * chore: fix test cases * chore: fix lint issue * chore: fix lint issue again * chore: revert service.api.test.ts changes
Co-authored-by: Sai Sankeerth <[email protected]>
…3794) * fix: update order_id in checkout events, messageId in pixel events * chore: add shopifyDetails support * chore: add shopifyDetails for shopify server side events from pixel * chore: set id property in the webhook event as messageId for pixel serverside event * chore: update tests
…3822) * chore: add network handler file for ga4 v2 in v0 implementation flow * chore: add tests
* feat: onboard tune destination * chore: test cases added * chore: file name updated * chore: import fix * chore: updated mappings * chore: updated transform.js * chore: updated test cases * chore: small fix * chore: router test cases added * chore: minor fix --------- Co-authored-by: Sai Sankeerth <[email protected]>
* feat: support for multiple zap urls * fix: update endpoint to array * fix: use forEach instead of map, remove unused dependency --------- Co-authored-by: Sai Sankeerth <[email protected]>
* fix: str.replace is not a function * fix: resolving comments
* chore: allow only mapped in properties, update event name * chore: remove redundant checks * chore: add jsdoc descriptions * chore: address comments
* feat: endpoint fix for tune destination * chore: minor fix
sanpj2292
force-pushed
the
feat.update_on_twitter_ads_integration
branch
from
fd910f1
to
548bfaa
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
Updated Twitter Ads integration to include two additional identifiers: ip_address and user_agent.
What is the related Linear task?
Resolves INT-2704
Doc: https://developer.x.com/en/docs/x-ads-api/measurement/web-conversions/api-reference/conversions
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.