Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: salesforce refactor #3824

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from

chore: resolve conflict

1abe194
Select commit
Loading
Failed to load commit list.
Open

chore: salesforce refactor #3824

chore: resolve conflict
1abe194
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2024 in 0s

89.05% (+0.03%) compared to b5baa75

View this Pull Request on Codecov

89.05% (+0.03%) compared to b5baa75

Details

Codecov Report

Attention: Patch coverage is 93.00699% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.05%. Comparing base (b5baa75) to head (1abe194).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/v0/util/salesforce/common.ts 90.90% 4 Missing ⚠️
src/v0/util/salesforce/legacy.ts 91.66% 3 Missing ⚠️
src/v0/destinations/salesforce/transform.js 60.00% 2 Missing ⚠️
src/v0/util/salesforce/oauth.ts 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3824      +/-   ##
===========================================
+ Coverage    89.02%   89.05%   +0.03%     
===========================================
  Files          610      613       +3     
  Lines        32959    33034      +75     
  Branches      7789     7804      +15     
===========================================
+ Hits         29341    29420      +79     
- Misses        3305     3331      +26     
+ Partials       313      283      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.