fix: adding logger for undefined source event #3879
Conversation
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3879/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3879 +/- ##
========================================
Coverage 89.05% 89.05%
========================================
Files 618 618
Lines 33071 33072 +1
Branches 7814 7815 +1
========================================
+ Hits 29452 29453 +1
Misses 3336 3336
Partials 283 283 ☔ View full report in Codecov by Sentry. |
|
| @@ -28,6 +28,11 @@ export class SourceController { | |||
| ); | |||
| ctx.body = resplist; | |||
| } catch (err: any) { | |||
There was a problem hiding this comment.
No need to mention module again in error message - we have structured logging now. Focus on mentioning the error message.
events can't be logged, it's a security risk - how did you overlooked it ? Is there specific reason to log events ?
cc: @sanpj2292
There was a problem hiding this comment.
how did you overlooked it ? Is there specific reason to log events ?
The inclusion of events was a call we took to understand what is the event which is causing a problem. The reason is we don't have a lot of context on what kind of event was received to us & even though we get the error message, we would not be in a position to properly identify the problem and come up with a fix.
In this particular bugsnag issue, we saw that sourceEvents came in as a non-array which means there is some problem in adaption logic. And is it undefined, string, object -- we absolutely have no-clue
We will remove events from getting logged but we should definitely find an alternate (if not already in consideration or present) to address this
There was a problem hiding this comment.
@shrouti1507 let's remove events from the log getting emitted for an error
What are the changes introduced in this PR?
We have got bugsnag error :
Adding logger to get more info
What is the related Linear task?
Resolves INT-2873
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.