Upgrade ndarray and other deps #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, I forget to update tests file. I will fix it later today |
|
Fixed, Let's rerun CI |
|
hi - I was here to press the ci button but I was wondering if @termoshtt wants to chime in too |
|
It seems like we should bump MSRV. Or limit the version of clap. Which one would you like? |
|
Hi - any update on this. This seems to be holding back ndarray updates downstream? |
| @@ -37,7 +37,7 @@ rand = "0.8.3" | |||
| thiserror = "1.0.24" | |||
|
|
|||
| [dependencies.ndarray] | |||
| version = "0.15.2" | |||
| version = "0.16.0" | |||
There was a problem hiding this comment.
Suggested change
| version = "0.16.0" | |
| version = ">=0.15.0, <0.17" |
This would make it easier to use as a library downstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump ndarray from 0.15.6 to 0.16.0
Bump approx from 0.4.0 to 0.5
Bump criterion from 0.3.4 to 0.5.1