Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Allow m:* to specify all mouse ids at once #842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jyn514
Copy link

@jyn514 jyn514 commented Sep 22, 2024

Previously, each mouse input device had to be specified explicitly in the config file. Now, all mice can be specified at once using m:*. To avoid backwards compatibility issues, * retains its existing meaning of "all keyboard devices".

To avoid capturing our own mouse output, the virtual pointer device is now marked as virtual (previously only the virtual keyboard was marked as virtual).

@jyn514
Copy link
Author

jyn514 commented Sep 22, 2024

i would like to add tests for this, but the test suite fails for me locally even without any changes :/ so it would be kind of difficult for me to make sure my new test passes.

chord-double.t: PASSED
WARNING: Insufficient output, timing out one more time...
chord-hold.t: ERROR: Extraneous keys.
Input:
a down
b down
199ms
x down
x up
a up
b up
1ms
a down
b down
200ms
x down
x up
a up
b up

Expected Output:     Output:
a down               a down
b down               b down
x down               x down
x up                 x up
a up                 a up
b up                 b up
control down         a down
x down               b down
x up                 x down
control up           x up
                     a up
                     b up

@lobre
Copy link

lobre commented Sep 23, 2024

Should a mention be made in the manpage?

Previously, each mouse input device had to be specified explicitly in the config file.
Now, all mice can be specified at once using `m:*`.
To avoid backwards compatibility issues, `*` retains its existing meaning of "all keyboard devices".

To avoid capturing our own mouse output, the virtual pointer device is now marked as virtual (previously only the virtual keyboard was marked as virtual).
@jyn514
Copy link
Author

jyn514 commented Sep 23, 2024

good call! done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants