Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names of transformer tests and files to match class names #284

Merged
merged 9 commits into from
Apr 16, 2019

Conversation

crupley
Copy link
Contributor

@crupley crupley commented Apr 15, 2019

Related issues

#278

Describe the proposed solution
Update names of some test classes and files to match name of the class they are testing

Describe alternatives you've considered
None

Additional context
None

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #284 into master will decrease coverage by 3.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #284     +/-   ##
=========================================
- Coverage    86.4%   82.51%   -3.9%     
=========================================
  Files         319      319             
  Lines       10453    10453             
  Branches      351      545    +194     
=========================================
- Hits         9032     8625    -407     
- Misses       1421     1828    +407
Impacted Files Coverage Δ
...alesforce/op/cli/gen/templates/SimpleProject.scala 0% <0%> (-100%) ⬇️
.../scala/com/salesforce/op/cli/gen/ProblemKind.scala 0% <0%> (-100%) ⬇️
...cala/com/salesforce/op/cli/gen/FileInProject.scala 0% <0%> (-100%) ⬇️
...in/scala/com/salesforce/op/cli/CommandParser.scala 0% <0%> (-98.12%) ⬇️
...cala/com/salesforce/op/cli/gen/ProblemSchema.scala 0% <0%> (-96.56%) ⬇️
...src/main/scala/com/salesforce/op/cli/gen/Ops.scala 0% <0%> (-94%) ⬇️
...ain/scala/com/salesforce/op/cli/SchemaSource.scala 0% <0%> (-87.94%) ⬇️
...a/com/salesforce/op/cli/gen/ProjectGenerator.scala 0% <0%> (-87.5%) ⬇️
...in/scala/com/salesforce/op/cli/CliParameters.scala 0% <0%> (-80.96%) ⬇️
...src/main/scala/com/salesforce/op/cli/CliExec.scala 0% <0%> (-80%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ddca9...41c513f. Read the comment docs.

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@@ -78,7 +78,7 @@ class OpLdaTest extends FlatSpec with TestSparkContext {
.toSeq
.map(_.getAs[Vector](0))

Spec[OpLdaTest] should "convert document term vectors into topic vectors" in {
Spec[OpLDATest] should "convert document term vectors into topic vectors" in {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec[OpLDA]

@tovbinm tovbinm merged commit 78396ff into salesforce:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants