Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ssr): add test for dynamic imports #4878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nolanlawson
Copy link
Collaborator

Details

Add a test to demonstrate the issue with #4875

I would like to test more cases here (like import()ing a non-literal), but that causes the SSR tests to crash with an unhandled rejection.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner November 15, 2024 22:01
Copy link
Contributor

❌ An unexpected error occurred while attempting to start the test stage of workflow 254236. Please try to start the stage again, or reach out to #nucleus-talk for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant