Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump derive-new to 0.6 #506

Closed
wants to merge 1 commit into from
Closed

Conversation

fee1-dead
Copy link

This will unify syn use to all be 2.0.

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 517fbff
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/66781b790f96850008a2c403

Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What I understand is that the only reason for a new minor version is that syn 2 bumps the minimal required rust version to 1.56. This doesn't apply to Salsa which already requires Rust 1,75

@nikomatsakis
Copy link
Member

@fee1-dead seems to have a conflict... perhaps with #505 ?

@fee1-dead
Copy link
Author

Resolved.

@nikomatsakis
Copy link
Member

Argh, more conflicts.

@nikomatsakis
Copy link
Member

Sorry @fee1-dead I didn't merge this earlier, are you up for a rebase?

@nikomatsakis
Copy link
Member

Included in #541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants