Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] [3006.x] Migrate workflows off AWS #67005

Open
wants to merge 72 commits into
base: 3006.x
Choose a base branch
from
Open

[wip] [3006.x] Migrate workflows off AWS #67005

wants to merge 72 commits into from

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Oct 28, 2024 •
edited
Loading

What does this PR do?

  • Migrate off aws runners
    • Use github enterprise runners for linux based workflows in place of self hosted runners on aws
  • Migrate off S3 caching for workflows
    • Use github's cache instead of s3
    • We may need to cut back on what we cache. iirc, github's cache was not scaling for us.

What issues does this PR fix or reference?

Fixes

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dwoz dwoz requested a review from a team as a code owner October 28, 2024 00:56
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add some gh runners [3006.x] Add some gh runners Oct 28, 2024
@dwoz dwoz changed the title [3006.x] Add some gh runners [wip] Add some gh runners Oct 28, 2024
@dwoz dwoz changed the title [wip] Add some gh runners [wip] [3006.x] Add some gh runners Oct 28, 2024
dmurphy18
dmurphy18 previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clean up pre-commit
Wondering about distinct lack of Arm64, is everything going to be x86_64 ?

@dwoz
Copy link
Contributor Author

dwoz commented Oct 28, 2024

Need to clean up pre-commit Wondering about distinct lack of Arm64, is everything going to be x86_64 ?

No, we have linux-x86_64 and linux-arm64 runners. I just needed to add them to the linter config.

@dwoz dwoz force-pushed the gh_runners branch 2 times, most recently from 4e15567 to 0fb2ff1 Compare November 8, 2024 23:41
twangboy
twangboy requested changes Nov 11, 2024
View reviewed changes
.github/workflows/test-action-windows.yml
@@ -1,5 +1,5 @@
---
name: Test Artifact
name: Test Artifact(macOS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy requested changes

@dmurphy18 dmurphy18 dmurphy18 left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
test:os:fedora-40-arm64 Run Tests Against Fedora 40 Arm64 test:os:fedora-40 Run Tests Against Fedora 40 x86_64 test:os:photonos-4 Run Tests Against PhotonOS 4 x86_64 test:os:photonos-5 Run Tests Against PhotonOS 5 x86_64 test:os:rockylinux-8-arm64 Run Tests Against RockyLinux 8 Arm64 test:os:rockylinux-8 Run Tests Against RockyLinux 8 x86_64 test:os:rockylinux-9-arm64 Run Tests Against RockyLinux 9 Arm64 test:os:rockylinux-9 Run tests on rockylinux 9 (x86_64) test:os:ubuntu-22.04-arm64 Run Tests Against Ubuntu 22.04 Arm64 test:os:ubuntu-22.04 Run Tests Against Ubuntu 22.04 x86_64 test:os:windows-2019 Run Tests Against Windows 2019 x86_64 test:os:windows-2022 Run tests on windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwoz @twangboy @dmurphy18