xsbt-web-plugin 4.2.4 -> sbt-war 5.0.0-M2

[earldouglas]

We might want to wait for the non-milestone 5.0.0 release, in which case this PR can serve as a placeholder.

sbt-war 5 uses com.heroku:webapp-runner, which uses Tomcat (currently version 10.1.28, which targets the 6.0 servlet spec); would we want to use the Eclipse Jetty runner instead?

[earldouglas]

This might require other documentation updates around the Scalatra ecosystem.

[takezoe]

Yeah, we will work on it once this PR is merged.

[takezoe]

Thank you for raising this. Looks like we need to fix CI😅 Will work on it in another PR.

[takezoe]

@earldouglas CI has been fixed in the master branch. Could you rebase this pull request on it?

would we want to use the Eclipse Jetty runner instead?

In theory, using Tomcat wouldn't be a problem as Scalatra is a pure servlet-based framework which doesn't rely on container specific features.

However, Jetty is used for many purposes in Scalatra, like integration test support, standalone deployment, etc. So, it would be better to use Jetty by default if possible.

[earldouglas]

CI has been fixed in the master branch

Thanks!

it would be better to use Jetty by default if possible

Gotcha. I'll experiment with using Jetty by default instead.

Marking this PR as draft until these are both addressed:

• rebase on scalatra/master
• experiment with Jetty instead of (or in addition to -- perhaps with a config setting) Tomcat as the default container (Experiment with Jetty in place of Tomcat earldouglas/sbt-war#979)