fix issue #6 #7
Open
fix issue #6 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个修改略粗暴... |
|
但没太看明白那句判断想要做什么 |
|
只针对 JS 文件进行包裹，但是这样判断不严谨，只能排除掉常用的后缀名了。 |
在原来的基础上加了个条件判断是否是前端常见的文件类型，如果是的话就不处理。 这样就能有效避免没加js后缀但是路径中有点号被误解析成非JS文件的情况了。 现在`isNotJSFile`这个正则里只加了`.css`和`.html`，以后遇见前端里可能的文件类型再做添加
|
看看最新的commit呢@@ |
|
我已经修改提交了，还是感谢 PR |
|
好的的>_< |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为避免
m[1] === 'js'将路径中有点号的情况过滤掉，于是把整个条件都去掉了。因为在这个项目下spm test运行不起来，所以没试过测试用例，不过在自己的项目上做了简单的测试，应该没有问题。
对源码理解可能不够透彻>_<�不知道这样修改是否遗漏了一些情况