Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ignore Coverage] #4 - Digestion params generalization #2341

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Feb 9, 2024

Generalizes digestion parameters in common parameters to enable rna digestion and protein digestion.

In the task windows, I had to move all things dependent upon the digestion agent being a protease into an if clause that casts the IDigestionParams.DigestionAgent into a protease

Needed to improve code coverage so I found a few miscelaneous spots to do so. ModTypeForTreeViewModel and the Glyco Node class

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 87.78626% with 16 lines in your changes missing coverage. Please review.

Project coverage is 93.00%. Comparing base (4a0a5e8) to head (1ed889e).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
...etaMorpheus/EngineLayer/Indexing/IndexingEngine.cs 66.66% 1 Missing and 3 partials ⚠️
MetaMorpheus/TaskLayer/MetaMorpheusTask.cs 90.00% 1 Missing and 2 partials ⚠️
...pheus/TaskLayer/CalibrationTask/CalibrationTask.cs 71.42% 0 Missing and 2 partials ⚠️
MetaMorpheus/TaskLayer/GPTMDTask/GPTMDTask.cs 71.42% 0 Missing and 2 partials ⚠️
...pheus/TaskLayer/GlycoSearchTask/GlycoSearchTask.cs 85.71% 0 Missing and 1 partial ⚠️
...us/TaskLayer/MbrAnalysis/SpectralRecoveryRunner.cs 0.00% 0 Missing and 1 partial ⚠️
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 83.33% 0 Missing and 1 partial ⚠️
MetaMorpheus/TaskLayer/SearchTask/SearchTask.cs 87.50% 0 Missing and 1 partial ⚠️
...etaMorpheus/TaskLayer/XLSearchTask/XLSearchTask.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2341      +/-   ##
==========================================
+ Coverage   92.79%   93.00%   +0.20%     
==========================================
  Files         137      137              
  Lines       21170    21172       +2     
  Branches     2924     2935      +11     
==========================================
+ Hits        19645    19691      +46     
+ Misses       1045      998      -47     
- Partials      480      483       +3     
Files with missing lines Coverage Δ
MetaMorpheus/EngineLayer/CommonParameters.cs 95.28% <100.00%> (-0.24%) ⬇️
...gineLayer/CrosslinkSearch/CrosslinkSearchEngine.cs 91.10% <100.00%> (+0.01%) ⬆️
...pheus/EngineLayer/FdrAnalysis/FdrAnalysisEngine.cs 96.50% <100.00%> (ø)
...EngineLayer/FdrAnalysis/PEPValueAnalysisGeneric.cs 96.10% <100.00%> (ø)
MetaMorpheus/EngineLayer/GlycoSearch/Node.cs 88.00% <ø> (+21.33%) ⬆️
...cificEnzymeSearch/NonSpecificEnzymeSearchEngine.cs 87.47% <100.00%> (ø)
...neLayer/ProteinParsimony/ProteinParsimonyEngine.cs 98.83% <100.00%> (ø)
MetaMorpheus/EngineLayer/Silac/SilacConversions.cs 97.83% <ø> (ø)
MetaMorpheus/EngineLayer/SpectralMatch.cs 99.71% <100.00%> (ø)
...GuiFunctions/ViewModels/ModTypeForTreeViewModel.cs 100.00% <100.00%> (+48.00%) ⬆️
... and 13 more

... and 1 file with indirect coverage changes

@nbollis nbollis changed the title #4 - [Waiting on Spectral Match Generalization]Digestion params generalization #4 - Digestion params generalization Mar 5, 2024
@nbollis nbollis changed the title #4 - Digestion params generalization #4 - [Waiting on Spectral Match Generalization] Digestion params generalization Mar 5, 2024
@nbollis nbollis changed the title #4 - [Waiting on Spectral Match Generalization] Digestion params generalization #4 - Digestion params generalization Mar 7, 2024
@trishorts
Copy link
Contributor

wherein nic embraces the var side

@nbollis nbollis changed the title #4 - Digestion params generalization [Ignore Coverage] #4 - Digestion params generalization Apr 11, 2024
@nbollis nbollis requested review from trishorts and elaboy May 9, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants