Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extconf: respect AR and RANLIB in recipes on darwin #3338

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshheinrichs-shopify
Copy link

@joshheinrichs-shopify joshheinrichs-shopify commented Nov 15, 2024

What problem is this PR intended to solve?

When using Nix on Darwin, we ideally should be latching onto the Nix-provided AR and RANLIB. Without this, when blocking Xcode via sandbox-exec, I see errors like this while attempting to install the gem, since we end up using the default ar and runlib

xcode-select: note: No developer tools were found, requesting install.
If developer tools are located at a non-default location on disk, use `sudo xcode-select --switch path/to/Xcode.app` to specify the Xcode that you wish to use for command line developer tools, and cancel the installation dialog.
See `man xcode-select` for more details.

Have you included adequate test coverage?

No but this seems relatively harmless?

Does this change affect the behavior of either the C or the Java implementations?

No

When using Nix on Darwin, we ideally should be latching onto the
Nix-provided AR and RANLIB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant