Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typo in Management API interfaces #833

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryami333
Copy link
Contributor

There was inconsistent/incorrect naming of the Typescript interfaces related to the ManagementAPI (ISbContentMangmntAPI and ISbManagmentApiResult respectively). In this pull-request I just rename the interfaces.

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

How to test this PR

Nothing to test - simple renaming. Running npx tsc and seeing no type errors ensures that there were no regressions.

What is the new behavior?

No new functional behaviour.

Copy link
Contributor Author

@ryami333 ryami333 Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of whitespace/indentation changes because this file had not been correctly formatted with Prettier. See this PR where I set a formatting baseline. Once that is merged I can rebase this PR to make the diffs less noisy.

In the meantime, please hide whitespace changes in code-review.

EDIT: rebased onto main - no formatting changes here now.

@alvarosabu
Copy link
Contributor

Once that is merged I can rebase this PR to make the diffs less noisy.

Hi @ryami333 thanks for taking care of it. One thing about rebasing. We had problems in the past with our automatic semantic release not grabbing the correct versions due to the use of rebase. In general, use merge commits instead. This ensures that the history remains linear and clear, allowing the semantic release tool to accurately determine the correct versions based on the commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants