Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove AssemblyProcessor unused option #2481

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jklawreszuk
Copy link
Collaborator

PR Details

This PR removes unused parameter for AssemblyProcessor. Because of recent changes It is never used

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR
Copy link
Member

Kryptos-FR commented Oct 9, 2024

How does it determine it needs to generate a module initializer then? Another way to say it: how to we tell to not generate one?

Is it only based on the attribute? In that case, did we check that all previously generated initializer through the parameter do have that attribute?

@IXLLEGACYIXL
Copy link
Collaborator

IXLLEGACYIXL commented Oct 9, 2024

How does it determine it needs to generate a module initializer then? Another way to say it: how to we tell to not generate one?

Is it only based on the attribute? In that case, did we check that all previously generated initializer through the parameter do have that attribute?

if you dont want a module intializer generated then dont use stride.core.moduleinitializer
generated shaders use system moduleinitializer now
and all previous module initializers get generated through roslyn now in https://github.com/stride3d/stride/blob/master/sources/core/Stride.Core.CompilerServices/Generators/ModuleInitializerGenerator.cs

when is the scenario to not use an existing module initializer?

assemblyprocessor doesnt od anything anymore with the module initializers

@Eideren Eideren marked this pull request as draft November 10, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants