Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Get LocalAppData path from Environment.SpecialFolder enum #2511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Get LocalAppData path from Environment.SpecialFolder enum #2511

wants to merge 1 commit into from

Conversation

Jklawreszuk
Copy link
Collaborator

@Jklawreszuk Jklawreszuk commented Nov 8, 2024 •
edited
Loading

PR Details

Getting LocalAppData path shouldn't be hardcoded if we want more universal code for all platforms. It should be received from Environment.GetFolderPath with Environment.SpecialFolder enum which contains common paths for OS folders.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk Jklawreszuk changed the title feat: Get LocalAppData path from Environment.SpecialFolder object feat: Get LocalAppData path from Environment.SpecialFolder enum Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jklawreszuk