New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grading PR [DO NOT MERGE] #42

Open

martypdx wants to merge 2 commits into tableau-app:master from martypdx:master

martypdx commented Jun 21, 2017

Comments and feedback, not for merging.

Reducers look good. Missing LOADING and ERROR actions for most server API actions.
Nice use of styled components and overall React and Redux looks idiomatic :)
Too bad you couldn't get to having avatars, or at the least use gravatar.
Don't hardcode image url's in components. Import images, or even with placeholders externalize them from the component, images.THUMBNAIL_COVER

martypdx added 2 commits

June 21, 2017 13:26


          initial grading commit

f448c35


          in-code feedback

190953f

martypdx changed the title ~~initial grading commit [DO NOT MERGE]~~ Grading PR [DO NOT MERGE]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet