Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: taosConn add atomic closed flag #266

Merged
merged 1 commit into from
May 20, 2024

Conversation

yinheli
Copy link
Contributor

@yinheli yinheli commented May 20, 2024

reference issue: #228
reference pr: #265

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 73.29%. Comparing base (575719f) to head (8f5bfe1).

Files Patch % Lines
taosWS/connection.go 40.00% 3 Missing and 3 partials ⚠️
taosWS/statement.go 0.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   73.29%   73.29%           
=======================================
  Files          62       62           
  Lines        6733     6749   +16     
=======================================
+ Hits         4935     4947   +12     
- Misses       1249     1250    +1     
- Partials      549      552    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@huskar-t huskar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huskar-t huskar-t merged commit a378bca into taosdata:main May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants