-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gray out options toggle on crypto #94
base: master
Are you sure you want to change the base?
Conversation
greying out, not hide the options toggle when crypto is selected
Haha you've read my mind, love it |
We should do the same for |
Absolutely, I'm on it! |
I went into working on this thinking What's the constraint I need to check for to disable this?
I guess I'm just asking, does pre-post work for crypto at all? |
Yeah, pre / post isn't applicable for |
Options? Do you mean crypto? And for "everything" else, I actually notice some changes on non-crypto symbols when in non-1D time frames. To be clear, are you saying pre-post should only work for non-crypto symbols in the 1D timeframe, because if that's the case then that's not what's happening. |
Yes sorry, crypto. Yeah, that's what should be happening. Can you give me some examples where pre / post is changing things for non-1D time frames or crypto? |
Ahh right, because I use the Post Market price as the last datapoint when it's toggle on vs Regular Market price when it's off, which alters the last datapoint on all the timeframes. I can easily fix that, I don't really think it makes sense to show the post-market price on the other time frames. What do you think? |
Yeah, it doesn't strike me as a useful metric outside of that. It's only really usable in the 1D timeframe. So with this PR, to clarify, I'll be graying out pre-post entirely for crypto and only on non-1D timeframes for others. I should probably wait for that fix so I can rebase and push. |
Sounds like a plan. I'll try to tackle that sometime tomorrow. |
Inspired by #93's behaviour with the
Volumes 'v'
item in the toggles, this relaxes #37 and better resolves #49.