Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Object.freeze tests for resizable TypedArrays #4324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Object.freeze tests for resizable TypedArrays #4324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions test/built-ins/Object/freeze/typedarray-backed-by-resizable-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@
esid: sec-object.freeze
description: >
Object.freeze throws on non-0-length TypedArrays backed by resizable
buffers but do not throw on 0-length ones
buffers
features: [resizable-arraybuffer]
includes: [resizableArrayBufferUtils.js]
---*/

// Freezing non-OOB non-zero-length TAs throws.
for (let ctor of ctors) {
const rab = CreateResizableArrayBuffer(4 * ctor.BYTES_PER_ELEMENT, 8 * ctor.BYTES_PER_ELEMENT);
const fixedLength = new ctor(rab, 0, 4);
Expand All @@ -36,9 +35,15 @@ for (let ctor of ctors) {
const fixedLength = new ctor(rab, 0, 0);
const fixedLengthWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT, 0);
const lengthTrackingWithOffset = new ctor(rab, 4 * ctor.BYTES_PER_ELEMENT);
Object.freeze(fixedLength);
Object.freeze(fixedLengthWithOffset);
Object.freeze(lengthTrackingWithOffset);
assert.throws(TypeError, () => {
Object.freeze(fixedLength);
});
assert.throws(TypeError, () => {
Object.freeze(fixedLengthWithOffset);
});
assert.throws(TypeError, () => {
Object.freeze(lengthTrackingWithOffset);
});
}
// If the buffer has been resized to make length-tracking TAs zero-length,
// freezing them also doesn't throw.
Expand All @@ -47,7 +52,11 @@ for (let ctor of ctors) {
const lengthTracking = new ctor(rab);
const lengthTrackingWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT);
rab.resize(2 * ctor.BYTES_PER_ELEMENT);
Object.freeze(lengthTrackingWithOffset);
assert.throws(TypeError, () => {
Object.freeze(lengthTrackingWithOffset);
});
rab.resize(0 * ctor.BYTES_PER_ELEMENT);
Object.freeze(lengthTracking);
assert.throws(TypeError, () => {
Object.freeze(lengthTracking);
});
}
Loading