Wallet Connect & Pre-order #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was
linked to
issues
Oct 25, 2021
tx0c
reviewed
Oct 25, 2021
|
|
||
| <main>{children}</main> | ||
|
|
||
| <Footer /> |
There was a problem hiding this comment.
I've merged this PR for other PRs can be handled faster, but just realized this change is reverting what's done in #23,
the gatsby-theme-i18n actually has an issue gatsbyjs/themes#138 that is wrapping only the main page, not the layout, so the layout is always getting default hard-coded en
https://nft-develop.matters.news/zh/ is always showing en in header & footer, unless that is wanted; or otherwise will have to move back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.env.production.jsonand.env.development.json[1];gatsby@4since it's a stable release and works fine [2];<Layout>, otherwise they will be re-rendered on page transition;components/Layout/Header/LanguageSwitchtocomponents/LanguageSwitchand reused byLayout/Footer[3];TODO
Upcoming
[1] For local dev, please run
cp .env.development.json .env.jsonfirst;[2] Dependence issue still exist, please run
npm install --legacy-peer-depswhen installing deps;[3] Language switching doesn't work on my local, @tx0c could you take a little check if I am wrong editing?