for multi database connection #2612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes a refactor of the search functionality in the Administrate module. The changes include improvements to the query parsing and filtering mechanisms. The search now supports more complex queries and filters, improving the overall search experience.
|
Ah, nice thanks! I think if we're going to introduce multi-database support (which we should, as it's a Rails default option now), we're going to need to think about testing for that situation, it might not just be here that's a problem (although you'd presumably tried this out and not hit anything else!) but we also might accidentally break it in future. Do you have any thoughts on how best we might do that? The first idea which comes to mind is another GitHub Action to spin up multiple databases and fetch records from different ones, but that's probably quite a bit of work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the same time, I want to use multi-database connections. But the query builder of Search::Query doesn't support this. so I decided to use the connection of @scoped_resource and rewrite this code.