StrSize() usage checking #6412

pierregondois · 2024-11-06T13:01:01Z

Description

Replace StrSize by StrLen and add comments about StrSize usage.

Breaking change?
- Breaking change - Does this PR cause a break in build or boot behavior?
- Examples: Does it add a new library class or move a module to a different repo.
Impacts security?
- Security - Does this PR have a direct security impact?
- Examples: Crypto algorithm change or buffer overflow fix.
Includes tests?
- Tests - Does this PR include any explicit test code?
- Examples: Unit tests or integration tests.

StrSize() account the terminating NULL character and cannot return 0. Replace StrSize() StrLen(). BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4859 Reported-by: Tormod Volden <[email protected]> Signed-off-by: Pierre Gondois <[email protected]>

StrSize() cannot return 0. As done in other packages, StrSize() checks the length of the string doesn't exceed PcdMaximumUnicodeStringLength. Add comments to make it more obvious. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4859 Reported-by: Tormod Volden <[email protected]> Signed-off-by: Pierre Gondois <[email protected]>

samimujawar

Thank you for these fixes.
These changes look good to me.

tianocore-assign-reviewers bot requested review from ardbiesheuvel, leiflindholm, niruiyu and samimujawar November 6, 2024 13:01

pierregondois force-pushed the pg/StrSize branch from 0f3dc21 to 57f94e4 Compare November 6, 2024 13:27

samimujawar approved these changes Nov 6, 2024

View reviewed changes