Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensible defaults: fontsize #146

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PallHaraldsson
Copy link

No description provided.

@PallHaraldsson
Copy link
Author

PallHaraldsson commented Apr 27, 2020

FYI: I would like to go even larger, 40 would be nice for me, and doesn't get cut off when windows maximized.

When background is not noisy, 30 is ok (but when it is 40+ is better), and way better (for me) than 14. I know you can set this, but then can't use the macro. 30 is a compromise for those who do not (want to) maximize the window (or know how...).

[skip ci]
@timholy
Copy link
Owner

timholy commented Apr 27, 2020

On my system, 30 is almost comically large. I'm guessing there's something not sufficiently invariant. What's your monitor resolution?

julia> using Gtk

julia> Gtk.screen_size()
(1920, 1080)

@timholy
Copy link
Owner

timholy commented May 7, 2020

Bump. If we can figure out where the lack of invariance is coming from, that might help.

@PallHaraldsson
Copy link
Author

PallHaraldsson commented May 7, 2020

Actually I also have:

julia> Gtk.screen_size()
(1920, 1080)

but your screen might be larger, blowing up pixels and fonts in size, than on my curved screen. I opted to try such recently, and others (flat) being sold were bigger, not always with higher resolution.

While you could calculate some size from screen density, I don't see NOT doing so being a problem. I see the size of the font, in relation to the (default) size of the opened window to be of most concern.

The "variance" is probably my "comically" bad eyesight (actually not that bad, I'm ok with defaults elsewhere, e.g. here on Github I think unchanged, but it only has white non-noisy background), something worth having in mind for others, there's no harm in bigger, while there is in smaller. Yes, I could change size to bigger (or others to smaller).

@timholy
Copy link
Owner

timholy commented May 7, 2020

I doubt it's just eyesight; with a setting of 40 it feels like each character is 5% of the height of my screen. Which is a lot. So there must be something else going on...

@PallHaraldsson
Copy link
Author

PallHaraldsson commented May 9, 2020

Just so we're on the same page, this is what I see with 30, the compromise I have in the PR (i.e. not 40):

image

And admittedly, yes, the text gets cut off, even on both sides, something I thought I had avoided by the compromise value (as I meant to, even for original size window, but what modern developer doesn't have a larger screen), but when maximizing the window, I couldn't locate any such place in that graph.

Compared to with the default, and yes, my eyesight isn't that bad, I can read the part on the white background, but only "ir.jl ite [something] line ...":

image

Note, this is even smaller, after uploading to GitHub (unless I double click to get full, or almost original size), and here I can read none of this.

And for you, all may get blown up on your bigger monitor, so keep that in mind. And e.g. the picture in the README is blown up a lot compared to when using, at least for me.

@PallHaraldsson
Copy link
Author

FYI, with the default size I did find an unusual case where gets cut off, even with maximized, so whatever size (unless even smaller), people may need the manual setting:

image

@PallHaraldsson
Copy link
Author

PallHaraldsson commented May 12, 2020

It was hard to see in the previous picture, but as in this one, line is -1, maybe a bug, or meaning I hit assembly code, or you know what?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants