Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors identified with cppcheck. #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix errors identified with cppcheck. #20

wants to merge 2 commits into from

Conversation

jbatista
Copy link

@jbatista jbatista commented Nov 4, 2018

Proposal to fix issues identified with cppcheck:

  1. eval.c(812): buf[blen] = 0 will write outside of array buf if blen = NSTRING.
  2. random.c(143): if condition is always false since c is unsigned int; presumably it was meant as 0xa0 <= c <= 0xc0.

jianwang-qau
jianwang-qau reviewed Apr 7, 2019
View reviewed changes
random.c Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianwang-qau jianwang-qau jianwang-qau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbatista @jianwang-qau